Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update version resolution logic to be more resilient #2169

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Update StorageOptions to resolve its version from maven metadata rather than manifest version. A jar can only have one MANIFEST.mf thereby leading to storage thinking it is a version it is not.

In particular, if a program is shaded, this change will now allow for the actual version of storage to be carried through.

Related googleapis/google-api-java-client#1419

Update StorageOptions to resolve their version from maven metadata rather than manifest version. A jar can only have on MANIFEST.mf thereby leading to storage thinking it is a version it is not.

In particular, if a program is shaded, this change will now allow for the actual version of storage to be carried through.

Related googleapis/google-api-java-client#1419
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Aug 17, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner August 17, 2023 18:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Aug 17, 2023
@BenWhitehead BenWhitehead merged commit c89d275 into main Aug 23, 2023
16 checks passed
@BenWhitehead BenWhitehead deleted the version-resilience branch August 23, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants